Add support for C14N #119
Merged
Add support for C14N #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslan
reviewed
Aug 26, 2025
Contributor
Author
|
@jameslan this is still a WIP but let me know what you think about the changes |
jameslan
reviewed
Nov 24, 2025
- Replace xmlC14NDocDumpMemory with xmlC14NExecute + xmlOutputBufferCreateIO - Remove document cloning workaround (xmlCopyNode, xmlNewDoc) by implementing proper node-level canonicalization - Add canonicalize() and canonicalizeToString() methods to both XmlDocument and XmlNode classes - Introduce XmlC14NIsVisibleCallback type for custom node filtering during canonicalization - Update C14NOptions interface with better type definitions and documentation - Remove obsolete utility classes (XmlNodeSetWrapper) and simplify memory management - Expand test coverage with comprehensive tests for all C14N modes, node-level canonicalization, comments handling, and inclusive namespaces
…nt/node methods, adjust memory handling and callbacks
…ray(string[]) and free(Pointer)
jameslan
reviewed
Nov 28, 2025
|
Coverage after merging c14n into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jameslan
approved these changes
Nov 28, 2025
Owner
jameslan
left a comment
jameslan
left a comment
There was a problem hiding this comment.
Many thank for all the effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still a lot of work to do here but I wanted to gauge your opinion before proceeding any further.
In particular because of the changes that I made to existing code, interaction with the existing code (particulary regarding disposables), and the bindings that were added.
Furthermore I don't really know how to get around the unsupported node types when used with NodeSet canonicalization and createNode in
isVisibleCallback.The changes needed for just the plain Document canonicalization, and Node canonicalization are minimal. Most of the changes were needed to accommodate the NodeSet canonicalization and the callback canonicalization, so it is probably worth considering if those are even needed.