heapless strings in service discovery to avoid doing too many hacks#100
Merged
jamesmunns merged 4 commits intomainfrom Aug 24, 2025
Merged
Conversation
Owner
|
@cramt postcard-schema v0.2.5 released, and CI is sad :D |
jamesmunns
reviewed
Aug 24, 2025
| #[cfg(not(feature = "std"))] | ||
| let _ = topics | ||
| .clone() | ||
| .unicast_borrowed::<ErgotDeviceInfoTopic>(dest, info); |
Owner
There was a problem hiding this comment.
If the type is now owned (because it's a heapless string), you probably want to use unicast here not unicast_borrowed
| /// | ||
| /// Terminates when the timeout is reached | ||
| #[cfg(feature = "tokio-std")] | ||
| #[cfg(feature = "std")] |
Owner
There was a problem hiding this comment.
Using tokio-std here was intentional, we use tokio::time::timeout below.
Collaborator
Author
|
also ensured that all ergot tests pass in both std and nostd features |
Collaborator
Author
|
the ci will be happy |
jamesmunns
approved these changes
Aug 24, 2025
jamesmunns
deleted the
alex/heapless_strings_in_service_discovery_to_avoid_hacks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently using the git version of postcard due to needing heapless v0.9 support