Separate embedded-io-async RxWorker target/controller modes#133
Merged
jamesmunns merged 2 commits intomainfrom Sep 7, 2025
Merged
Separate embedded-io-async RxWorker target/controller modes#133jamesmunns merged 2 commits intomainfrom
jamesmunns merged 2 commits intomainfrom
Conversation
This isn't a great fix, but fine for now. We should revisit this.
jamesmunns
commented
Sep 7, 2025
jamesmunns
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, RxWorker in a controller configuration will do the same "wait for address assignment" that the target does, which doesn't generally work if both the controller and target are waiting for the other to make the first move.
This gives separate constructors so we can get out of that deadlock.
Thanks to @AndWass for reporting!