Merged
Conversation
Bump embassy dependencies such that we can use the latest embassy-executor and embassy-time crates. Along the way, embassy-usb v0.4 support is dropped. Inspired by a similar PR on `postcard-rpc`.
Contributor
Author
|
(PS: more of a question, really. Is this something you're willing to do? That is, drop support for e-u <= 0.4 just to bump other embassy dependencies?) |
Owner
|
@felipebalbi happy to drop old e-usb, and will merge if the CI is all green. I'm a bit less worried about stability in ergot than p-rpc for now :) |
Owner
|
@felipebalbi it doesn't look like this updates embassy-executor (we're still on 0.7), though the ergot crate itself doesn't use that directly, only the device crates in the I'm also willing to take an update pass on that if you have interest in the future! Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump embassy dependencies such that we can use the latest embassy-executor and embassy-time crates. Along the way, embassy-usb v0.4 support is dropped.
Inspired by a similar PR on
postcard-rpc.