Skip to content

Discovery improvements#154

Merged
jamesmunns merged 1 commit intojamesmunns:mainfrom
MakerPnP:discovery-improvements-1
Oct 24, 2025
Merged

Discovery improvements#154
jamesmunns merged 1 commit intojamesmunns:mainfrom
MakerPnP:discovery-improvements-1

Conversation

@hydra
Copy link
Copy Markdown
Collaborator

@hydra hydra commented Oct 24, 2025

  • run discovery on a set interval.
  • don't abort and restart discovery when another future finishes before discovery.
  • sync the interval and timeouts of the two do_discovery methods.
  • run discovery, then wait for the interval, instead of the other way around.

* run discovery on a set interval.
* don't abort and restart discovery when another future finishes before discovery.
* sync the interval and timeouts of the two `do_discovery` methods.
* run discovery, then wait for the interval, instead of the other way around.
Copy link
Copy Markdown
Owner

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hydra!

@hydra hydra marked this pull request as ready for review October 24, 2025 12:25
@jamesmunns jamesmunns merged commit 7316b41 into jamesmunns:main Oct 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants