Improve documentation and debugging context for NetStackSendError::WrongPortKind.#157
Merged
jamesmunns merged 1 commit intojamesmunns:mainfrom Nov 9, 2025
Merged
Conversation
jamesmunns
reviewed
Nov 6, 2025
| if skt_ref.attrs.kind != hdr.kind { | ||
| return Err(NetStackSendError::WrongPortKind); | ||
| return Err(NetStackSendError::WrongPortKind { | ||
| expected: skt_ref.attrs.kind, |
Owner
There was a problem hiding this comment.
maybe we want to call these something like "socket_kind" and "packet_kind", to make it more clear which is which?
hydra
added a commit
to MakerPnP/machine
that referenced
this pull request
Nov 8, 2025
* includes PR 157 - jamesmunns/ergot#157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds debugging and gives some hints in the documentation.
See code changes.