Skip to content

fix: enforce chat attachment mime validation #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enforce chat attachment mime validation #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion web/components/project/chat/components/chat-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import React, {
useRef,
useState,
} from "react"
import { toast } from "sonner"
import { getIconForFile } from "vscode-icons-js"
import { Button } from "../../../ui/button"
import {
Expand Down Expand Up @@ -448,6 +449,10 @@ function ChatInputContextMenu() {
[contextTabs]
)
const files = React.useMemo(() => getAllFiles(fileTree), [fileTree])
const isAllowedFileType = (type: string) =>
ALLOWED_FILE_TYPES.some((allowed) => allowed === type)
const isAllowedImageType = (type: string) =>
ALLOWED_IMAGE_TYPES.some((allowed) => allowed === type)
const handleFileUpload: React.MouseEventHandler<HTMLDivElement> = (event) => {
event.preventDefault()
const fileInput = document.createElement("input")
Expand All @@ -456,6 +461,17 @@ function ChatInputContextMenu() {
fileInput.onchange = (e) => {
const file = (e.target as HTMLInputElement).files?.[0]
if (file) {
const fileType = file.type
if (!fileType || !isAllowedFileType(fileType)) {
toast.error("Unsupported file type. Select a valid document or code file.")
;(e.target as HTMLInputElement).value = ""
return
}
if (isAllowedImageType(fileType)) {
toast.error("Use the Images option to upload image files.")
;(e.target as HTMLInputElement).value = ""
return
}
const reader = new FileReader()
reader.onload = () => {
addContextTab({
Expand Down Expand Up @@ -485,6 +501,12 @@ function ChatInputContextMenu() {
fileInput.onchange = (e) => {
const file = (e.target as HTMLInputElement).files?.[0]
if (file) {
const fileType = file.type
if (!fileType || !isAllowedImageType(fileType)) {
toast.error("Only image files are supported in the Images section.")
;(e.target as HTMLInputElement).value = ""
return
}
const reader = new FileReader()
reader.onload = () => {
addContextTab({
Expand Down Expand Up @@ -592,5 +614,5 @@ export {
ChatInputContextMenu,
ChatInputModelSelect,
ChatInputSubmit,
ChatInputTextarea,
ChatInputTextarea
}