Handle strncpy in a way compatible with gcc-9 linting#9
Merged
jamesodhunt merged 1 commit intojamesodhunt:masterfrom Aug 1, 2019
Merged
Handle strncpy in a way compatible with gcc-9 linting#9jamesodhunt merged 1 commit intojamesodhunt:masterfrom
jamesodhunt merged 1 commit intojamesodhunt:masterfrom
Conversation
gcc-9 is now more rigorous about ensuring strncpy() is used correctly and errors out if the bound argument appears to be derived from the source argument: /usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=] Leverage this compiler functionality, and in the process fix a possible 1-byte buffer overflow.
Closed
Owner
|
Thanks @vorlonofportland - hope all well with you! 😉 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcc-9 is now more rigorous about ensuring strncpy() is used correctly and
errors out if the bound argument appears to be derived from the source
argument:
/usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
Leverage this compiler functionality, and in the process fix a possible
1-byte buffer overflow.