Add re-entrance guard to fix infinite recursion crash #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates Problem: - Setting configuration = oldValue in catch block caused infinite recursion - This was exposed when workingDirectory check was added to didSet - Led to crash with EXC_BAD_ACCESS during app launch Solution: - Added isUpdatingConfiguration flag to prevent re-entrance - Now safely restores old configuration on backend creation failure - Maintains consistent state between configuration and backend This makes configuration updates bulletproof and future-proof for any backend type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #28 introduced a crash when updating working directory at runtime. The
configuration = oldValueline in the catch block caused infinite recursion:didSettriggers whenworkingDirectorychangesconfiguration = oldValuedidSetagain with differentworkingDirectoryEXC_BAD_ACCESSSolution
Added re-entrance guard using
isUpdatingConfigurationflag:didSetfrom re-entering during configuration updatesTesting
Related
🤖 Generated with Claude Code