cleanup: пропущенный $ в rm в register_xkeen#36
Merged
Conversation
В register_xkeen.sh:108 в rm среднее имя без знака доллара,
удалялся буквальный файл old_start_file в cwd, а не реальный
${initd_dir}/S99xkeenstart. В норме mv на :67 уже унёс файл, но
при abort/permission errors между mv и rm легаси init-скрипт
оставался в /opt/etc/init.d.
Проверено на Hopper SE arm64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Заметил мелкую опечатку в register_xkeen_initd.
На строке 108 в команде rm пропущен
$передold_start_file:При апгрейде с 1.x, если
mvна :67 не успел перенести легаси${initd_dir}/S99xkeenstart(abort, permission errors между mv и rm),rmпытался удалить файл буквально с именемold_start_fileв текущей директории. Реальный S99xkeenstart оставался в/opt/etc/init.dи переживал апгрейд.Добавил
$, теперь rm удаляет правильный файл.