Skip to content

fix segfault on checking arg existence #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamolnng merged 2 commits into from
Oct 28, 2019
Merged

fix segfault on checking arg existence #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54296ca
fix sf on checking arf existance
vadikrobot Oct 27, 2019
2489225
made clear what is being checked
jamolnng Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions argparse.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,14 @@ class ArgumentParser {
if (!_help) {
for (auto &a : _arguments) {
if (a._required) {
if (_variables.find(a._name) == _variables.end()
&& _variables.find(_pairs.find(a._name)->second) == _variables.end()) {
throw ArgumentNotFound(a, _pairs);
if (_variables.find(a._name) == _variables.end()) {
// Check if a pair name does not exist. If it does exist check that
// there is not a variable with that name
if (_pairs.find(a._name) == _pairs.end() ||
_variables.find(_pairs.find(a._name)->second) ==
_variables.end()) {
throw ArgumentNotFound(a, _pairs);
}
}
}
}
Expand Down