Rust client #30
Merged
Rust client #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgb
force-pushed
the
paulgb/rust-client-wip
branch
from
08fbf62 to
f97e3a7
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| impl ApiToken { | ||
| pub fn new(token: String) -> Self { | ||
| let (id, token) = token.split_once(SEPARATOR).unwrap(); |
Contributor
There was a problem hiding this comment.
Using unwrap() here can cause a panic if the token does not contain the separator. Consider handling this case gracefully, perhaps by returning a Result or using expect() with a clear error message.
rolyatmax
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rust client and command-line program. The command-line program is intended to replace the typescript/oclif CLI app.