Skip to content

Update Notification for non-release versions does not work #3669

@pljones

Description

@pljones

Describe the bug

It looks like there's a bug in the version comparison between a non-release version of the client/server that's checking it's own version and the source version number.

For example "3.12.0rc1" isn't getting flagged that there's an update available when an update server has "3.12.0" available. "3.11.0" works fine.

I think any string other than dev* should sort before the release, with dev* sorting after the release.

To Reproduce

In all the following cases, the version chosen should be before the current release.

  1. Install a release version of the client or server with a version number less than current, run the GUI
  2. See the notification of an update
  3. Install a development version of the next release (3.x.xdev...), run the GUI
  4. See the notification of an update
  5. Install a tagged pre-release version of the next release (tag in "alpha*", "beta*" and "rc*"), run the GUI

Expected behavior

  1. See the notification of an update

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    Status

    Triage

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions