Hoist block offset multiplication to top of the loops #2297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more efficient, and should avoid the CodeQL warnings about multiplication overflow within array indices or vector offsets in buffer.cpp and server.cpp Replaces the changes that were done in jamulussoftware#2292
softins
force-pushed
the
codeql-multiply-v2
branch
from
f61991b to
8d656ed
Compare
pljones
approved these changes
Jan 27, 2022
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
It looks nicer than what was there...
ann0see
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Improve buffer offset calculation to avoid multiplication overflow warnings and improve efficiency
Context: Fixes an issue?
#2292 did not fix the CodeQL warnings, so this is an alternative and better approach.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready and should work.
What is missing until this pull request can be merged?
Smoke test with a server or client.Client built on Pi works fine.Checklist