Skip to content

Update nl_NL app translation for 3.8.2 #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 3 commits into from
Jan 29, 2022
Merged

Update nl_NL app translation for 3.8.2 #2314

ann0see merged 3 commits into from
Jan 29, 2022

Conversation

@henkdegroot
Copy link
Contributor

@henkdegroot henkdegroot commented Jan 28, 2022 •
edited
Loading

Short description of changes

Dutch app translation update for 3.8.2

Context: Fixes an issue?

Fixes: #2305

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Complete

What is missing until this pull request can be merged?

Review by @jerogee

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@henkdegroot
Copy link
Contributor Author

henkdegroot commented Jan 28, 2022

@jerogee , can you please review the update/changes?

hoffie
hoffie approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine to me, thanks again! :)

  • Translator listed in the src/util.cpp, optionally add link to PR or code
  • Punctuation and spacing consistent.
  • Signal words consistent (“ASIO”, “Buffer”)
  • App translations: No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)
  • Installer translations: Passes tools/check-wininstaller-translations.sh

Note: Merge should still wait if there's more feedback/adjustments.

src/res/translation/translation_nl_NL.ts Outdated
</message>
<message>
<location filename="../../util.h" line="610"/>
<location filename="../../util.h" line="606"/>
Copy link
Member

@hoffie hoffie Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's relevant, but I'm not sure why this happened. Have you been on master when performing the translations?

Copy link
Contributor Author

@henkdegroot henkdegroot Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on master (which I updated first to be in sync) before adding the translation. Though I did pre-work on the translation and did copy text from another file which I tested first.
I will update the PR and correct this line (and line 2097).

Copy link
Member

@hoffie hoffie Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the PR and correct this line (and line 2097).

I don't think it's relevant, probably more a pointer. I was just wondering how this could happen.

Copy link
Contributor Author

@henkdegroot henkdegroot Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved it already, it should not have happened. Well spotted!

@hoffie hoffie added this to the Release 3.8.2 milestone Jan 28, 2022
jerogee
jerogee suggested changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@jerogee jerogee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor textual improvements.

src/res/translation/translation_nl_NL.ts Outdated
<location filename="../../clientsettingsdlg.cpp" line="361"/>
<source>If you need to add additional directories to the Connect dialog Directory drop down, you can enter the addresses here.&lt;br&gt;To remove a value, select it, delete the text in the input box, then move focus out of the control.</source>
<translation type="unfinished"></translation>
<translation>Als u extra adresboeken wilt toevoegen aan de adresboek keuze in het verbingsvenster, dan kunt u hier de adressen invoeren.&lt;br&gt;Als u een waarde wilt verwijderen, selecteert u deze, verwijdert u de tekst in het invoervak en verplaatst u de focus uit de vak.</translation>
Copy link
Contributor

@jerogee jerogee Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/verbingsvenster/verbindingsvenster/

Copy link
Contributor Author

@henkdegroot henkdegroot Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected in commit 9f39e4d

src/res/translation/translation_nl_NL.ts Outdated
<location filename="../../connectdlg.cpp" line="87"/>
<source>If you know the IP address or URL of a server, you can connect to it using the Server name/Address field. An optional port number can be added after the IP address or URL using a colon as a separator, e.g, %1. The field will also show a list of the most recently used server addresses.</source>
<translation type="unfinished"></translation>
<translation>Als u het IP-adres of de URL van de server weet, dan kunt u daar verbinding meemaken door deze in te voeren in het Servernaam/Adres veld. Een optioneel poortnummer kan worden toegevoegd na het IP-adres of de URL met een dubbele punt als scheidingsteken, b.v. %1. Het veld laat ook een lijst zien met de meest recent gebruikte serveradressen.</translation>
Copy link
Contributor

@jerogee jerogee Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/meemaken/mee maken/

Copy link
Contributor Author

@henkdegroot henkdegroot Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected in commit 9f39e4d

src/res/translation/translation_nl_NL.ts Outdated
<location filename="../../util.cpp" line="1893"/>
<source>Released under the GNU General Public License version 2 or later (GPLv2)</source>
<translation type="unfinished"></translation>
<translation>Gereleased onder de GNU General Public License version 2 or later (GPLv2)</translation>
Copy link
Contributor

@jerogee jerogee Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/version 2 or later/versie 2 of recenter/

Copy link
Contributor Author

@henkdegroot henkdegroot Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected in commit 9f39e4d

hoffie
hoffie approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @henkdegroot.
Thanks for the review and the corrections @jerogee!

CI failed, probably due to flakiness. Restarted.

@hoffie hoffie requested a review from ann0see January 29, 2022 07:36
@hoffie
Copy link
Member

hoffie commented Jan 29, 2022

@ann0see Should be squash-merged with Co-authored-by: jerogee <dev@nlp-ml.io> added to the commit message, I think.

@ann0see ann0see merged commit bdf2bf0 into jamulussoftware:master Jan 29, 2022
@ann0see ann0see removed their request for review January 29, 2022 11:20
@henkdegroot henkdegroot deleted the translate-r3_8_2-dutch branch January 29, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffie hoffie hoffie approved these changes

+1 more reviewer

@jerogee jerogee jerogee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 3.8.2

Development

Successfully merging this pull request may close these issues.

Update nl_NL app translation for 3.8.2

4 participants

@henkdegroot @hoffie @jerogee @ann0see