Skip to content

Conversation

@RobyDati
Copy link
Contributor

@RobyDati RobyDati commented Jan 28, 2022

Updated point 5. of ## iOS section with more details on Xcode settings in order to get the Jamulus app installed on iPhone device. Added the following details: "For instance, you can use your free Apple Developer Program Account as a Personal Team, and set it up under Xcode Menu->Preferences->Accounts. Then choose a Bundle Identifier at your choice in the relevant field under General Tab in section Identity. Then go to Signing & Capabilities tab, section Identity, the Automatic manage signing option and you should get Team: (Your Name) (Personal Team), Bundle identifier: (the same you modified on General Tab), Provisioning Profile: Xcode Management Profile, Signing Certificate: Apple Development (your e-mail used for signing in to Apple)"

Short description of changes

Context: Fixes an issue?

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

What is missing until this pull request can be merged?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Updated point 5. of ## iOS  section with more details on Xcode settings in order to get the Jamulus app installed on iPhone device. Added the following details: "For instance, you can use your free Apple Developer Program Account as a Personal Team, and set it up under Xcode Menu->Preferences->Accounts. Then choose a Bundle Identifier at your choice in the relevant field under General Tab in section Identity. Then go to Signing & Capabilities tab, section Identity, the Automatic manage signing option and you should get Team: (Your Name) (Personal Team), Bundle identifier: (the same you modified on General Tab), Provisioning Profile: Xcode Management Profile, Signing Certificate: Apple Development (your e-mail used for signing in to Apple)"
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you very much for updating this file.

GitHub can be very confusing so don’t panic 😀. In general it looks good. There might still be some small changes needed for the styling (add more bullet points to give the text more structure)? But if you don’t want to update it yourself it’s ok.

Mainly the file should have you as contributor listed to know who edited what and when.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment. Will try to fire up my macOS environment.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be squash merged

@hoffie hoffie added this to the Release 3.8.2 milestone Jan 28, 2022
@hoffie
Copy link
Member

hoffie commented Jan 29, 2022

Thanks, @RobyDati! Do you want to be added to the list of contributors within Jamulus?
You can do this yourself as part of this (see src/util.cpp) or we can do it, if you want?

CHANGELOG: Docs: iOS signing instructions have been added to the COMPILING.md documentation

@RobyDati
Copy link
Contributor Author

RobyDati commented Jan 29, 2022 via email

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I have pushed an update to this PR and will merge on CI green.

@hoffie hoffie merged commit 312ea60 into jamulussoftware:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants