-
Notifications
You must be signed in to change notification settings - Fork 238
Update COMPILING.md #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update COMPILING.md #2315
Conversation
Updated point 5. of ## iOS section with more details on Xcode settings in order to get the Jamulus app installed on iPhone device. Added the following details: "For instance, you can use your free Apple Developer Program Account as a Personal Team, and set it up under Xcode Menu->Preferences->Accounts. Then choose a Bundle Identifier at your choice in the relevant field under General Tab in section Identity. Then go to Signing & Capabilities tab, section Identity, the Automatic manage signing option and you should get Team: (Your Name) (Personal Team), Bundle identifier: (the same you modified on General Tab), Provisioning Profile: Xcode Management Profile, Signing Certificate: Apple Development (your e-mail used for signing in to Apple)"
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you very much for updating this file.
GitHub can be very confusing so don’t panic 😀. In general it looks good. There might still be some small changes needed for the styling (add more bullet points to give the text more structure)? But if you don’t want to update it yourself it’s ok.
Mainly the file should have you as contributor listed to know who edited what and when.
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment. Will try to fire up my macOS environment.
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be squash merged
|
Thanks, @RobyDati! Do you want to be added to the list of contributors within Jamulus? CHANGELOG: Docs: iOS signing instructions have been added to the COMPILING.md documentation |
|
Thank you Christian,
OK I wish to be added to the list, just in case I hope I may contribute more in the future. I am not sure I can do it myself, if you can do it for me I'll be grateful.
Best regards
Roberto
… Il 29/01/2022 08:51 Christian Hoffmann ***@***.***> ha scritto:
Thanks, @RobyDati https://github.com/RobyDati ! Do you want to be added to the list of contributors within Jamulus?
You can do this yourself as part of this (see src/util.cpp https://github.com/RobyDati/jamulus/blob/5cd09b6365f4d068e7a4ea58afeca11c33cd8997/src/util.cpp#L492 ) or we can do it, if you want?
CHANGELOG: Docs: iOS signing instructions have been added to the COMPILING.md documentation
—
Reply to this email directly, view it on GitHub #2315 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AUFWTFISU4QZVMFX3TCSDFLUYOL7JANCNFSM5NAWBJNQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
hoffie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I have pushed an update to this PR and will merge on CI green.
Updated point 5. of ## iOS section with more details on Xcode settings in order to get the Jamulus app installed on iPhone device. Added the following details: "For instance, you can use your free Apple Developer Program Account as a Personal Team, and set it up under Xcode Menu->Preferences->Accounts. Then choose a Bundle Identifier at your choice in the relevant field under General Tab in section Identity. Then go to Signing & Capabilities tab, section Identity, the Automatic manage signing option and you should get Team: (Your Name) (Personal Team), Bundle identifier: (the same you modified on General Tab), Provisioning Profile: Xcode Management Profile, Signing Certificate: Apple Development (your e-mail used for signing in to Apple)"
Short description of changes
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist