Skip to content

Addded sort by instrument and Edit menu option#356

Merged
corrados merged 5 commits intojamulussoftware:masterfrom
Alberstein8:master
Jun 13, 2020
Merged

Addded sort by instrument and Edit menu option#356
corrados merged 5 commits intojamulussoftware:masterfrom
Alberstein8:master

Conversation

@Alberstein8
Copy link
Copy Markdown
Contributor

  • Added a new sort option in Edit menu, Sort by instruments. Usefull for choirs for example, to gather same voices together. Based in Sort by name Possibility to change channel/user position ordering #178 code added in 3.5.6 original release.
  • Translation to German and Spanish of new Edit menu option.
  • Changed &amp letter of existing Edit menu option "&Sort Channel Users by Name" by "Sort Channel Users by &Name" as new menu item is "Sort Channel Users by &Instrument"

@corrados
Copy link
Copy Markdown
Contributor

Thanks for your code. Your "iReceivedInstrument = cChanInfo.iInstrument;" will not work correctly since you have to reset it correctly. But I want to store the complete info instead of the items separately.
I will do the implementation of storing the complete info now, then you can change your code to use this.

Another thing: I do not want to have another sort function. Please use "CAudioMixerBoard::ChangeFaderOrder ( const bool bDoSort )" but add a new function parameter telling the function to what parameter it shall do the sorting.

corrados added a commit that referenced this pull request Jun 13, 2020
corrados added a commit that referenced this pull request Jun 13, 2020
@corrados
Copy link
Copy Markdown
Contributor

corrados commented Jun 13, 2020

Ok, I have now changed the function:
void CAudioMixerBoard::ChangeFaderOrder ( const bool bDoSort,
const EChSortType eChSortType )
But not tested the sorting by the instrument.

@gilgongo gilgongo mentioned this pull request Jun 13, 2020
@corrados corrados merged commit 19f2b74 into jamulussoftware:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants