Addded sort by instrument and Edit menu option#356
Merged
corrados merged 5 commits intojamulussoftware:masterfrom Jun 13, 2020
Merged
Addded sort by instrument and Edit menu option#356corrados merged 5 commits intojamulussoftware:masterfrom
corrados merged 5 commits intojamulussoftware:masterfrom
Conversation
Contributor
Alberstein8
commented
Jun 12, 2020
- Added a new sort option in Edit menu, Sort by instruments. Usefull for choirs for example, to gather same voices together. Based in Sort by name Possibility to change channel/user position ordering #178 code added in 3.5.6 original release.
- Translation to German and Spanish of new Edit menu option.
- Changed & letter of existing Edit menu option "&Sort Channel Users by Name" by "Sort Channel Users by &Name" as new menu item is "Sort Channel Users by &Instrument"
Contributor
|
Thanks for your code. Your "iReceivedInstrument = cChanInfo.iInstrument;" will not work correctly since you have to reset it correctly. But I want to store the complete info instead of the items separately. Another thing: I do not want to have another sort function. Please use "CAudioMixerBoard::ChangeFaderOrder ( const bool bDoSort )" but add a new function parameter telling the function to what parameter it shall do the sorting. |
corrados
added a commit
that referenced
this pull request
Jun 13, 2020
corrados
added a commit
that referenced
this pull request
Jun 13, 2020
Contributor
|
Ok, I have now changed the function: |
Merged
Sort by instrument added, using the same function for sorting by name or instrument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.