Escape server and user names in the status HTML#381
Merged
corrados merged 1 commit intojamulussoftware:masterfrom Jun 20, 2020
Merged
Escape server and user names in the status HTML#381corrados merged 1 commit intojamulussoftware:masterfrom
corrados merged 1 commit intojamulussoftware:masterfrom
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape server and user names in the status HTML - currently if I set my username to something like
<i>AdamSthen it'll be passed through as is.The security impact of this is limited by the name size limit that CProtocol enforces, and by this feature not being used on most servers anyway. (At worst, though, if somebody's ignored the sensible advice in the Tips page and directly included the output in a PHP file, it might be possible to execute arbitrary code on the webserver using crafted channel names.)