Fix Pico HAL not being fully off when LED is LowActive()#152
Merged
jandelgado merged 1 commit intomasterfrom Apr 28, 2026
Merged
Fix Pico HAL not being fully off when LED is LowActive()#152jandelgado merged 1 commit intomasterfrom
jandelgado merged 1 commit intomasterfrom
Conversation
|
coverage: 96.781% (+0.01%) from 96.767% — fix_pico_hal_in_inverted_setup into master |
jandelgado
force-pushed
the
fix_pico_hal_in_inverted_setup
branch
2 times, most recently
from
2ece9e1 to
030485e
Compare
when LED is inverted (LowActive()) the PWM value must be set to 2^res since otherwise there will be a light remaining glim when the LED is supposed to be off.
jandelgado
force-pushed
the
fix_pico_hal_in_inverted_setup
branch
from
030485e to
37e5dcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when LED is inverted (LowActive()) the PWM value must be set to 2^res since otherwise there will be a light remaining glim when the LED is supposed to be off.