added module bindings #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automatically determine where userid.node bindings file is.
|
I've included this change in the new 1.0.0-beta version :D Please help me test! |
Author
|
Hi @cinderblock , Thanks for include this. We are currently upgrading dependencies, just in time 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jandre , I added bindings module dependency and removed the manual file requires.
Probably this will fix some of the opened issues related to the import of the module.
This fix will also make the module works with enclosejs.
The tests run fine. And we are using this version of the module with the software we are developing.
I have also fixed the versions of packages and rise the module version to 0.2.1
Thanks