Showing initial slide in infinite loop when going backwards (previous)#47
Merged
zautumnz merged 2 commits intojane:masterfrom Oct 14, 2017
Merged
Conversation
zautumnz
reviewed
Oct 14, 2017
| if (!slideBy) { | ||
| const [prevSlide] = this.getPartiallyObscuredSlides() | ||
| const prevInfinteSlide = (prevSlide === firstIndex) ? childCount - 1 : prevSlide | ||
| const [prevSlide] = Math.max(activeIndex - 1, firstIndex) |
Contributor
There was a problem hiding this comment.
Can you remove the destructuring here?
Contributor
Author
There was a problem hiding this comment.
Sorry. I have removed it.
Contributor
|
Thanks for the contribution! There's just one change needed on line 232, then I'll merge it in. |
Contributor
|
Thanks! |
Contributor
|
Released in 6.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Details
When going to previous slide while in infinite loop initial slide was skipped due to minor logic inconsistencies.
I have replaced this.getPartiallyObscuredSlides() with Math.max(activeIndex - 1, firstIndex) because this function is behaving strange and causes slider to show same slide as previous over and over. This is an issue on your demo where it breaks as slide nr 12.
Lines 233 and 238 are actually the same. They won't set slide index to last slide until initial slide is showing (until it is active)
Change Type
Change Level
Checklist
Other Context (if appropriate)
Screenshots (if appropriate)