Skip to content

Fix/include model file#71

Merged
mzouink merged 2 commits intojanelia-cellmap:mainfrom
neptunes5thmoon:fix/include_model_file
Oct 21, 2025
Merged

Fix/include model file#71
mzouink merged 2 commits intojanelia-cellmap:mainfrom
neptunes5thmoon:fix/include_model_file

Conversation

@neptunes5thmoon
Copy link
Copy Markdown
Contributor

similar to #49 . To be able to pip install from github files that are required but don't live in the src directory need to be included explicitly.

Copilot AI review requested due to automatic review settings September 16, 2025 21:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a packaging issue by ensuring that model files outside the src directory are properly included when installing the package from GitHub. The fix addresses a similar issue to #49 by explicitly including required model files in the package distribution.

  • Adds explicit inclusion of YAML model files in setuptools package data configuration
  • Updates MANIFEST.in to include the specific models.yaml file for distribution

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Adds package data configuration to include YAML files from models directory
MANIFEST.in Explicitly includes models/models.yaml file in package distribution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pyproject.toml
@mzouink mzouink merged commit f5cb70c into janelia-cellmap:main Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants