Fix/include model file#71
Merged
mzouink merged 2 commits intojanelia-cellmap:mainfrom Oct 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a packaging issue by ensuring that model files outside the src directory are properly included when installing the package from GitHub. The fix addresses a similar issue to #49 by explicitly including required model files in the package distribution.
- Adds explicit inclusion of YAML model files in setuptools package data configuration
- Updates MANIFEST.in to include the specific models.yaml file for distribution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adds package data configuration to include YAML files from models directory |
| MANIFEST.in | Explicitly includes models/models.yaml file in package distribution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mzouink
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to #49 . To be able to pip install from github files that are required but don't live in the src directory need to be included explicitly.