Skip to content

Test the staging action #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Test the staging action #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f11503
make a change to prompt
brianamarie Nov 1, 2019
a179130
Merge master into staging-test
github-learning-lab[bot] Mar 6, 2020
7cb976f
Update from deprecated nodejs8
janerikcarlsen Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sam-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Resources:
Properties:

# This function uses the Nodejs v8.10 runtime.
Runtime: nodejs8.10
Runtime: nodejs12.x

# This is the Lambda function's handler.
Handler: handler.lambdaHandler
Expand Down Expand Up @@ -46,4 +46,4 @@ Outputs:
# https://github.com/awslabs/serverless-application-model/blob/master/docs/internals/generated_resources.rst#api
StagingUrl:
Description: "Staging URL"
Value: !Sub "https://${ServerlessRestApi}.execute-api.${AWS::Region}.amazonaws.com/Prod/"
Value: !Sub "https://${ServerlessRestApi}.execute-api.${AWS::Region}.amazonaws.com/Prod/"
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ import Game from './game.js'

let p1, p2
while (!p1) {
p1 = window.prompt('Enter player 1 name:')
p1 = window.prompt('Who is player 1?')
}

while (!p2 && p1 !== p2) {
p2 = window.prompt(p1 === p2
? `Please enter a different name than ${p1}.`
: 'Enter player 2 name:')
: 'Who is player 2?')
}

window.onload = () => {
Expand Down