Skip to content

Use qualified output path for -share flag#343

Merged
Xyene merged 1 commit intojanestreet:masterfrom
EmeraldShift:fix-share-flag
Nov 25, 2025
Merged

Use qualified output path for -share flag#343
Xyene merged 1 commit intojanestreet:masterfrom
EmeraldShift:fix-share-flag

Conversation

@EmeraldShift
Copy link
Copy Markdown
Contributor

Fix a bug with -share where the share command was passed only the basename of the file to share, by using ~output_path instead of ~filename.

At tip, I can run

MAGIC_TRACE_SHARE_DOC=" Share the trace." \
MAGIC_TRACE_SHARE_COMMAND=/usr/bin/echo \
dune exec bin/magic_trace_bin.exe -- run true -o /tmp/true.fxt -share

and I no longer receive an exception, and the final output is /tmp/true.fxt.

Signed-off-by: Michael Jarrett <mjarrett@janestreet.com>
Copy link
Copy Markdown
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 419b84c into janestreet:master Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants