Tweak slice examples #274
Merged
Tweak slice examples #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests tweaking some of the examples for
slice.The comment for the first example mentioned "a new array", but the return value is a tuple. Since the input to
sliceis an array in this case, it seemed reasonable to remove the comment.A number of the other examples used
[:a :b :d :d :e](note that there are two instances of:d) as an argument toslice, but based on the surrounding information, I suspect the intent was to use[:a :b :c :d :e]so this was altered in some cases.Finally, I think error messages have changed since the original example was created so an update was made along those lines.