Fix 5G not being displayed when in 5G NSA mode#160
Merged
rslater-cs merged 1 commit intodevfrom Nov 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The 5G modem only works in 5G non-standalone mode in the UK as this is the predominant 5G connection method. Previously the active technology was identified using qmi commands but this only returns the achor technology which is always LTE (4G). Modem manager will show the active technology as
ltewhen on 4G andlte, 5gnrwhen on 5G.As the current method of mmcli info reporting put lists on the bus as individual endpoints this would have required GSM to keep a timeout based aggregation of access tech reports to figure out if we had LTE or LTE and 5Gnr, very messy. I have changed lists in mmcli to be formatted as string in the form
<item1>,<item2>,.... So now GSM just has to listen to one bus event in order to infer all access tech types. This required some factoring of other functions which now handle strings rather than tables.Screenshots/Recordings
Manual test
Manual test description
Run the code in a 5G area for the SIM you are using, making sure your SIM supports 5G. Check local-ui for the 5G mark on the primary modem
Added tests?
Added to documentation?