Skip to content

Fix 5G not being displayed when in 5G NSA mode#160

Merged
rslater-cs merged 1 commit intodevfrom
5g-modem
Nov 26, 2025
Merged

Fix 5G not being displayed when in 5G NSA mode#160
rslater-cs merged 1 commit intodevfrom
5g-modem

Conversation

@rslater-cs
Copy link
Contributor

@rslater-cs rslater-cs commented Nov 25, 2025

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

The 5G modem only works in 5G non-standalone mode in the UK as this is the predominant 5G connection method. Previously the active technology was identified using qmi commands but this only returns the achor technology which is always LTE (4G). Modem manager will show the active technology as lte when on 4G and lte, 5gnr when on 5G.

-----------------------------------
  Status   |                    lock: sim-pin2
           |          unlock retries: sim-pin (3), sim-puk (10), sim-pin2 (3), sim-puk2 (10)
           |                   state: connected
           |             power state: on
           |             access tech: lte <---
           |          signal quality: 91% (recent)
-----------------------------------
-----------------------------------
  Status   |                    lock: sim-pin2
           |          unlock retries: sim-pin (3), sim-puk (10), sim-pin2 (3), sim-puk2 (10)
           |                   state: connected
           |             power state: on
           |             access tech: lte, 5gnr <---
           |          signal quality: 67% (recent)
  -----------------------------------

As the current method of mmcli info reporting put lists on the bus as individual endpoints this would have required GSM to keep a timeout based aggregation of access tech reports to figure out if we had LTE or LTE and 5Gnr, very messy. I have changed lists in mmcli to be formatted as string in the form <item1>,<item2>,.... So now GSM just has to listen to one bus event in order to infer all access tech types. This required some factoring of other functions which now handle strings rather than tables.

Screenshots/Recordings

image

Manual test

  • 👍 yes
  • 🙅 no

Manual test description

Run the code in a 5G area for the SIM you are using, making sure your SIM supports 5G. Check local-ui for the 5G mark on the primary modem

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

@rslater-cs rslater-cs changed the title 5g modem Fix 5G not being displayed when in 5G NSA mode Nov 25, 2025
@rslater-cs rslater-cs changed the base branch from main to dev November 25, 2025 13:15
@rslater-cs rslater-cs marked this pull request as ready for review November 25, 2025 14:52
@rslater-cs rslater-cs requested review from corp0529 and cpunt November 25, 2025 14:52
Copy link
Contributor

@cpunt cpunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rslater-cs rslater-cs merged commit 463bdb4 into dev Nov 26, 2025
@cpunt cpunt deleted the 5g-modem branch December 3, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants