Fix tmux lint: prevent false failure when tpm is not installed#84
Merged
Conversation
The `run '~/.tmux/plugins/tpm/tpm'` at the end of tmux.conf caused `make lint` to fail on fresh machines or CI where tpm is not yet installed, even though the config itself is valid. Adding `|| true` inside the shell command string ensures tmux's `run` command does not propagate a non-zero exit when the tpm binary is missing. Closes #79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run '~/.tmux/plugins/tpm/tpm'at the end offiles/tmux/tmux.confcausedmake lintto exit non-zero on fresh machines or CI where tpm is not yet installed, even though the config is otherwise valid.|| trueinside the shell command string so tmux'srundoes not propagate a failure when the tpm binary is absent.Change
Test plan
make linton a machine without tpm installed —tmux: files/tmux/tmux.confcheck should now pass.make linton a machine with tpm installed — behaviour unchanged, tpm loads normally.Closes #79
Generated by Claude Code