Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

bug: model float parameters return from cortex is not rounded #1734

@louis-jan

Description

@louis-jan

Cortex version

1.0.3

Describe the issue and expected behaviour

When making requests to /models, it returns unrounded model parameter float values that differ from the values defined in the model.yml file.

The fix for #1387 wasn’t covered in the cases.

CleanShot 2024-11-28 at 09 33 43

CleanShot 2024-11-28 at 09 34 19

Expected results

  1. It should return rounded values that are defined in the model.yaml file.

Check after the fix

  1. Float numbers should have decimal places (maximum 2) and not round to an integer.
  2. Integer numbers should not be converted to floats with decimal places.

Steps to Reproduce

  1. Pull a model
  2. Get /models

Screenshots / Logs

CleanShot 2024-11-28 at 09 33 43

CleanShot 2024-11-28 at 09 34 19

What is your OS?

  • Windows
  • Mac Silicon
  • Mac Intel
  • Linux / Ubuntu

What engine are you running?

  • cortex.llamacpp (default)
  • cortex.tensorrt-llm (Nvidia GPUs)
  • cortex.onnx (NPUs, DirectML)

Hardware Specs eg OS version, GPU

No response

Metadata

Metadata

Assignees

Labels

type: bugSomething isn't working

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions