This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: consolidate download service #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
force-pushed
the
j/consolidate-download-service
branch
3 times, most recently
from
b93a501 to
73cf1a3
Compare
namchuai
requested review from
dan-menlo,
nguyenhoangthuan99 and
vansangpfiev
and removed request for
dan-menlo,
nguyenhoangthuan99 and
vansangpfiev
namchuai
force-pushed
the
j/consolidate-download-service
branch
from
ffe22a4 to
69bb241
Compare
vansangpfiev
reviewed
Oct 3, 2024
vansangpfiev
reviewed
Oct 3, 2024
vansangpfiev
reviewed
Oct 3, 2024
vansangpfiev
reviewed
Oct 3, 2024
namchuai
force-pushed
the
j/consolidate-download-service
branch
from
69bb241 to
67f742c
Compare
namchuai
force-pushed
the
j/consolidate-download-service
branch
from
67f742c to
5595f63
Compare
namchuai
force-pushed
the
j/consolidate-download-service
branch
from
5595f63 to
a38b56a
Compare
namchuai
force-pushed
the
j/consolidate-download-service
branch
from
a38b56a to
fd8b588
Compare
vansangpfiev
approved these changes
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Download servicefor sending event to client.Screenshots
Download events via websocket
Fixes Issues
Self Checklist