Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

feat: cortex pull and cortex engines install CLI uses API server #1550

Merged
merged 29 commits into from
Oct 29, 2024
Merged

feat: cortex pull and cortex engines install CLI uses API server #1550

merged 29 commits into from
Oct 29, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 25, 2024 •
edited by gabrielle-ong
Loading

Describe Your Changes

  • Add client websocket
  • Add progress bar for downloading
  • Call Server API for downloading
    image

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

vansangpfiev
vansangpfiev commented Oct 28, 2024
View reviewed changes
@vansangpfiev vansangpfiev marked this pull request as ready for review October 28, 2024 02:52
@vansangpfiev vansangpfiev requested a review from namchuai October 28, 2024 02:52
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai reviewed Oct 29, 2024
View reviewed changes
namchuai
namchuai approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm. Approved.

@vansangpfiev vansangpfiev merged commit 00af979 into dev Oct 29, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the feat/cli-websockets branch October 29, 2024 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

epic: cortex pull and cortex engines install CLI uses API server epic: Cortex has a better CLI UI for downloading

4 participants

@vansangpfiev @namchuai @sangjanai