Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

chore: cleanup httplib #1680

Merged
merged 2 commits into from
Nov 29, 2024
Merged

chore: cleanup httplib #1680

merged 2 commits into from
Nov 29, 2024

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Nov 14, 2024 •
edited
Loading

Describe Your Changes

  • Remove httplib. Using only libcurl for http request.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the j/cleanup-httplib branch 2 times, most recently from cb6076a to 80da991 Compare November 18, 2024 16:35
namchuai
namchuai commented Nov 22, 2024
View reviewed changes
@namchuai namchuai marked this pull request as ready for review November 22, 2024 07:39
@namchuai namchuai force-pushed the j/cleanup-httplib branch 3 times, most recently from e088ade to 689b350 Compare November 22, 2024 10:21
@namchuai namchuai requested a review from a team November 25, 2024 01:25
@namchuai namchuai force-pushed the j/cleanup-httplib branch 6 times, most recently from 33f1ac9 to a93314a Compare November 29, 2024 03:57
@namchuai namchuai force-pushed the j/cleanup-httplib branch 3 times, most recently from a7d8ecf to f9836b8 Compare November 29, 2024 07:44
@namchuai namchuai merged commit 9c95577 into dev Nov 29, 2024
5 checks passed
@namchuai namchuai deleted the j/cleanup-httplib branch November 29, 2024 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vansangpfiev vansangpfiev vansangpfiev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namchuai @vansangpfiev