Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: support user defined engine path #1687

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: support user defined engine path #1687

merged 1 commit into from
Nov 15, 2024

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Nov 14, 2024

Describe Your Changes

  • Support user defined engine path via env ENGINE_PATH

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the j/update-user-defined-engine-path branch from ccf9259 to 481a092 Compare November 15, 2024 01:17
@namchuai namchuai marked this pull request as ready for review November 15, 2024 04:28
@namchuai namchuai requested a review from a team November 15, 2024 04:28
@namchuai namchuai merged commit 3bf5f87 into dev Nov 15, 2024
9 of 10 checks passed
@namchuai namchuai deleted the j/update-user-defined-engine-path branch November 15, 2024 04:50
@louis-jan louis-jan mentioned this pull request Nov 15, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namchuai @nguyenhoangthuan99