Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: support path with special characters on windows #1730

Merged
merged 24 commits into from
Nov 28, 2024
Merged

fix: support path with special characters on windows #1730

merged 24 commits into from
Nov 28, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Nov 27, 2024 •
edited
Loading

Describe Your Changes

  • Support wide string path for windows

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan
Copy link
Contributor

louis-jan commented Nov 27, 2024

First attempt of testing:
It's able to run cortex.cpp server now. But llama.cpp legacy issue still there, it says could not find gguf file.

@gabrielle-ong gabrielle-ong mentioned this pull request Nov 28, 2024
Closed
@vansangpfiev vansangpfiev marked this pull request as ready for review November 28, 2024 10:32
@vansangpfiev vansangpfiev requested a review from a team November 28, 2024 10:32
@vansangpfiev vansangpfiev changed the title fix: utf8 fix: support path with special characters on windows Nov 28, 2024
namchuai
namchuai reviewed Nov 28, 2024
View reviewed changes
@vansangpfiev vansangpfiev merged commit 719de33 into dev Nov 28, 2024
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/utf8-compile branch November 28, 2024 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vansangpfiev @louis-jan @namchuai @sangjanai