Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Dec 3, 2024

Describe Your Changes

  • Signal to engine to stop inflight chat completion if it has request from client.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review December 10, 2024 03:16
@vansangpfiev vansangpfiev requested a review from a team December 10, 2024 03:16
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally looks good to me. Approved! ✅

@vansangpfiev vansangpfiev merged commit 4a839b4 into dev Dec 10, 2024
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/stop-inflight-chat branch December 10, 2024 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants