Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

This pull request includes changes to the engine/services/engine_service.cc file to improve the handling of paths in the LoadEngine and RegisterEngineLibPath methods. The most important changes involve the removal of buggy std::move (use after move) operations when pushing back paths into the std::vector.

Codebase simplification:

  • engine/services/engine_service.cc: Removed unnecessary std::move operations when pushing cuda_path and engine_dir_path into the paths vector in both the LoadEngine and RegisterEngineLibPath methods. [1] [2]## Describe Your Changes

@vansangpfiev vansangpfiev requested a review from namchuai January 7, 2025 02:10
@vansangpfiev vansangpfiev merged commit e286092 into dev Jan 7, 2025
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/use-after-move branch January 7, 2025 03:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants