This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: unit test for cohere and handle stop curl #1856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
remote-enginecomponent, focusing on enhancing the handling of streaming requests, improving status management, and adding new test cases. The most important changes include modifications to theStreamWriteCallbackfunction, updates to theRemoteEngine::MakeStreamingChatCompletionRequestandRemoteEngine::HandleChatCompletionmethods, and the addition of new test cases for theRemoteEngineTestsuite.Enhancements to streaming request handling:
engine/extensions/remote-engine/remote_engine.cc: Added checks and updates to theStreamWriteCallbackfunction to ensure thecontext->need_stopflag is correctly set and handled. [1] [2]Improved status management:
engine/extensions/remote-engine/remote_engine.cc: Added logic inRemoteEngine::MakeStreamingChatCompletionRequestto handle cases where no stop message is received, ensuring proper status reporting.engine/extensions/remote-engine/remote_engine.h: Introduced a newneed_stopboolean member in theStreamContextstruct to manage the stop condition for streaming requests.Template rendering improvements:
engine/extensions/remote-engine/remote_engine.cc: UpdatedRemoteEngine::HandleChatCompletionto ensure themodelfield is included in the response JSON if it is not already present.New test cases:
engine/test/components/test_remote_engine.cc: Added new test casesCohereRequestandCohereResponseto verify the correct handling of Cohere-specific requests and responses, including both streaming and non-streaming scenarios.## Describe Your ChangesFixes Issues
Self Checklist