Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request includes several changes to the engine module, focusing on improving error handling, bypassing model checks, and ensuring proper model path assignment. The most important changes include updates to the StartModel function in models.cc, the StreamWriteCallback function in remote_engine.cc, and the StartModel method in model_service.cc.

Error handling improvements:

Model path assignment:

  • engine/controllers/models.cc: Modified the StartModel function to assign the llama_model_path to model_path if model_path is null, ensuring the correct model path is used.

Model check bypass:

  • engine/services/model_service.cc: Added a condition to bypass the model check for vision models, allowing the StartModel method to proceed without checking for model existence in the database.

Code formatting:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev merged commit c2d8f61 into main Jan 17, 2025
6 checks passed
@vansangpfiev vansangpfiev deleted the fix/mistral branch January 17, 2025 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants