Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request introduces several changes to the Models and ModelSourceService classes to support filtering models by author and improve error handling. The most important changes include adding an optional author parameter to the ListModel method, implementing the GetRepositoryList method in ModelSourceService, and improving error handling in the StartModel and StopModel methods.

Enhancements to Models class:

  • Added an optional author parameter to the ListModel method to filter models by author. (engine/controllers/models.cc, engine/controllers/models.h) [1] [2] [3]

Enhancements to ModelSourceService class:

  • Implemented the GetRepositoryList method to fetch a list of repositories for a given author. (engine/services/model_source_service.cc, engine/services/model_source_service.h) [1] [2] [3]

Error handling improvements:

  • Added explicit casting to void for the return value of StopModel and LoadEngine methods to suppress unused result warnings. (engine/services/model_service.cc) [1] [2] [3]

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review February 20, 2025 03:49
@vansangpfiev vansangpfiev force-pushed the s/feat/supported-models-cortexso branch from f153b0b to 0491af9 Compare February 20, 2025 07:09
@vansangpfiev vansangpfiev force-pushed the s/feat/supported-models-cortexso branch from 0491af9 to 8d4df9f Compare February 20, 2025 07:14
@vansangpfiev vansangpfiev merged commit 663e6ea into dev Feb 20, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/feat/supported-models-cortexso branch February 20, 2025 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants