This repository was archived by the owner on Jul 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 181
fix: add more parameters to server start command #2032
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a4f2f7 to
cc811f7
Compare
cc811f7 to
0776c59
Compare
0bd5a91 to
e990557
Compare
Contributor
|
Preview URL: https://933f1d66.cortex-docs.pages.dev |
e990557 to
b09ff4e
Compare
…into s/fix/config-rc
qnixsynapse
approved these changes
Mar 13, 2025
Contributor
qnixsynapse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes several changes to the command-line interface and configuration management in the
engine/cliandengine/commondirectories. The most important changes include adding support for a newgithub_tokenconfiguration option, enhancing the command-line parser to handle empty configuration values, and updating the API server configuration to track changes in the server host.Enhancements to configuration management:
engine/common/api_server_configuration.h: Added support for a newgithub_tokenconfiguration option, including its declaration, initialization, and JSON serialization. [1] [2] [3] [4] [5] [6]engine/services/config_service.cc: Updated theUpdateApiServerConfigurationandGetApiServerConfigurationmethods to handle the newgithub_tokenconfiguration option. [1] [2] [3]Enhancements to command-line parser:
engine/cli/command_line_parser.cc: Modified theSetupConfigsCommandsandConfigUpdCmd::Execmethods to allow empty configuration values if permitted by the configuration metadata. [1] [2]engine/cli/command_line_parser.cc: Added a new--hostoption to thestartcommand and updated the callback to track changes in the server host. [1] [2]engine/cli/command_line_parser.h: Added a newserver_hostmember to theCommandLineParserclass.Fixes Issues
.cortexrc#1897Self Checklist