Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Mar 4, 2025

Describe Your Changes

This pull request introduces several updates to the handling of model configurations, particularly around the inclusion of a new mmproj field. The changes span multiple files and primarily focus on ensuring that the mmproj field is appropriately read, stored, and written in the configuration process.

Key changes include:

Model Configuration Updates:

  • Added a new mmproj field to the ModelConfig structure and ensured it is included when converting to and from JSON. (engine/config/model_config.h - [1] [2]
  • Updated the RemoteModelConfig structure to ensure consistent formatting. (engine/config/model_config.h - engine/config/model_config.hL38-R38)

YAML Handling Enhancements:

  • Modified YamlHandler::ReadYamlFile to add the mmproj file to the YAML configuration if it exists. (engine/config/yaml_config.cc - engine/config/yaml_config.ccR44-R57)
  • Updated YamlHandler::ModelConfigFromYaml to read the mmproj field from the YAML configuration. (engine/config/yaml_config.cc - engine/config/yaml_config.ccR148-R149)
  • Enhanced YamlHandler::UpdateModelConfig and YamlHandler::WriteYamlFile to handle the mmproj field. (engine/config/yaml_config.cc - [1] [2]

Model Service and Controller Adjustments:

Fixes Issues

Self Checklist

  • API: pull vision models, completion request via /v1/chat/completions

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Preview URL: https://0fdd70f7.cortex-docs.pages.dev

@vansangpfiev vansangpfiev marked this pull request as ready for review March 4, 2025 06:51
@vansangpfiev vansangpfiev merged commit db3a05a into main Mar 7, 2025
8 checks passed
@vansangpfiev vansangpfiev deleted the s/feat/pull-vision-models branch March 7, 2025 03:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants