This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: Exception Handling and multiline comment #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
approved these changes
Mar 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request addresses two key improvements in the codebase:
Updated the exception handling in the Text struct's ToJson method. The catch clause now correctly captures the exception by reference (const std::exception & e) instead of by value. This change prevents unnecessary copying of the exception object and adheres to best practices for exception handling in C++.
Commented out the unused GGUF_LOG macro in gguf_file.cpp using a block comment to resolve compiler complaints about multiline comments.
Fixes Issues
Self Checklist