This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: crash if invalid url is set #2142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gau-nernst
approved these changes
Mar 18, 2025
gau-nernst
reviewed
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes changes to improve URL validation in the
ModelServiceclass within theengine/services/model_service.ccfile. The primary focus is on enhancing error messages to provide clearer guidance on valid URL formats.Improvements to URL validation:
cpp::result<DownloadTask, std::string> ModelService::HandleDownloadUrlAsync: Enhanced error message to include a valid URL example when the URL is invalid or has insufficient path parameters.cpp::result<DownloadTask, std::string> ModelService::HandleDownloadUrlAsync: Removed redundant URL validation check for the number of path parameters.cpp::result<ModelPullInfo, std::string> ModelService::GetModelPullInfo: Enhanced error message to include a valid URL example when the URL is invalid or has insufficient path parameters.Fixes Issues
Self Checklist