Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: CI error on mac silicon and windows #383

Merged
merged 8 commits into from
Jan 29, 2024
Merged

fix: CI error on mac silicon and windows #383

merged 8 commits into from
Jan 29, 2024

Conversation

@hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Jan 29, 2024 •
edited
Loading

  • Mac silicon whisper.cpp (coreML build) error
  • Windows amd64 llama.cpp e2e test
  • Windows amd64 with CUDA llama.cpp e2e test - This cannot be run on CI because Nitro CI uses nvidia docker and does not have mounted physical device

@hiro-v hiro-v requested a review from hiento09 January 29, 2024 03:38
@hiro-v hiro-v self-assigned this Jan 29, 2024
@hiro-v hiro-v requested a review from tikikun January 29, 2024 08:11
@hiro-v hiro-v added the type: bug Something isn't working label Jan 29, 2024
tikikun
tikikun approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@tikikun tikikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiro-v hiro-v merged commit a600cf5 into main Jan 29, 2024
@hiro-v hiro-v deleted the 382-bug-fix-nitro-main-branch-ci-bugs branch January 29, 2024 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hiento09 hiento09 Awaiting requested review from hiento09

1 more reviewer

@tikikun tikikun tikikun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiro-v hiro-v

Labels

type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiro-v @tikikun