Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@louis-jan
Copy link
Contributor

Describe your changes

  • request_cancel should be called on done.
  • error does not goes through callback

@louis-jan louis-jan requested a review from tikikun February 15, 2024 13:20
Copy link
Contributor

@tikikun tikikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tikikun tikikun merged commit 7f5a20a into main Feb 15, 2024
@louis-jan louis-jan deleted the chore/request-cancel-on-done branch February 27, 2024 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants