Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@BachDao
Copy link

@BachDao BachDao commented Feb 26, 2024

  • The initial client establishes a connection with the server and initiates a model load operation.
  • During the loading process, a second client connects and observes that the "model_loaded_external" flag remains false, prompting it to attempt loading the model again, leading to a race condition.

@BachDao BachDao changed the title Fix race when model is loaded first time Resolve Race Condition During Initial Model Load Feb 26, 2024
@BachDao BachDao changed the title Resolve Race Condition During Initial Model Load Resolve race condition during initial model load Feb 26, 2024
@hiro-v hiro-v requested a review from tikikun February 27, 2024 03:10
@louis-jan
Copy link
Contributor

Great find!

@louis-jan
Copy link
Contributor

I don't know why it's stuck at loading the model on Mac; I'm switching to Windows to test again.

@BachDao
Copy link
Author

BachDao commented Feb 27, 2024

The last write to the flag should be write_released instead of relaxed, will update when I get back to my laptop.

Anw, if your Windows running x86, it should be fine, otherwise problem in somewhere else.

@louis-jan
Copy link
Contributor

The last write to the flag should be write_released instead of relaxed, will update when I get back to my laptop.

Anw, if your Windows running x86, it should be fine, otherwise problem in somewhere else.

Great, thank you! Let me know when you need me to test again.

@louis-jan
Copy link
Contributor

@BachDao request for help, could you please help rebase the latest main?

@tikikun
Copy link
Contributor

tikikun commented Apr 3, 2024

stale

@tikikun tikikun closed this Apr 3, 2024
@BachDao BachDao deleted the bug_fixs branch April 24, 2024 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants