Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

refactor: context should not be coupled in controller #455

Merged
merged 1 commit into from
Feb 29, 2024
Merged

refactor: context should not be coupled in controller #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ endif()

aux_source_directory(controllers CTL_SRC)
aux_source_directory(common COMMON_SRC)
aux_source_directory(context CONTEXT_SRC)
# aux_source_directory(filters FILTER_SRC) aux_source_directory(plugins
# PLUGIN_SRC) aux_source_directory(models MODEL_SRC)

Expand All @@ -87,7 +88,7 @@ aux_source_directory(common COMMON_SRC)

target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
# ${CMAKE_CURRENT_SOURCE_DIR}/models)
target_sources(${PROJECT_NAME} PRIVATE ${CTL_SRC} ${COMMON_SRC})
target_sources(${PROJECT_NAME} PRIVATE ${CTL_SRC} ${COMMON_SRC} ${CONTEXT_SRC})
# ${FILTER_SRC} ${PLUGIN_SRC} ${MODEL_SRC})
# ##############################################################################
# uncomment the following line for dynamically loading views set_property(TARGET
Expand Down
28 changes: 14 additions & 14 deletions common/base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ class BaseModel {

// Model management
virtual void LoadModel(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;
virtual void UnloadModel(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;
virtual void ModelStatus(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;
};

class BaseChatCompletion {
Expand All @@ -25,8 +25,8 @@ class BaseChatCompletion {

// General chat method
virtual void ChatCompletion(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;
};

class BaseEmbedding {
Expand All @@ -35,8 +35,8 @@ class BaseEmbedding {

// Implement embedding functionality specific to chat
virtual void Embedding(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;

// The derived class can also override other methods if needed
};
Expand All @@ -46,13 +46,13 @@ class BaseAudio {
virtual ~BaseAudio() {}
// Transcribes audio into the input language.
virtual void CreateTranscription(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;

// Translates audio into the input language.
virtual void CreateTranslation(
const HttpRequestPtr &req,
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
const HttpRequestPtr& req,
std::function<void(const HttpResponsePtr&)>&& callback) = 0;

// The derived class can also override other methods if needed
};
Loading