Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Install windows #47

Merged
merged 13 commits into from
Oct 6, 2023
Merged

Install windows #47

merged 13 commits into from
Oct 6, 2023

Conversation

@dotieuthien
Copy link
Contributor

@dotieuthien dotieuthien commented Oct 5, 2023 •
edited
Loading

  • Fix CMakeLists for dependencies
  • Add a line in llamaCPP controller to work on Windows because of conflict on our function and Windows built-in
  • Add guidline in README_temp

Address #27

tikikun
tikikun reviewed Oct 5, 2023
View reviewed changes
@dotieuthien dotieuthien linked an issue Oct 5, 2023 that may be closed by this pull request
Build and run Nitro on windows (with or without NVIDIA GPU support) #27
Closed
@dotieuthien dotieuthien added the P0: critical Mission critical label Oct 5, 2023
@dotieuthien dotieuthien self-assigned this Oct 5, 2023
hiro-v
hiro-v approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@hiro-v hiro-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok

@hiro-v hiro-v merged commit 6112ff3 into main Oct 6, 2023
@hiro-v hiro-v deleted the install-windows branch October 6, 2023 02:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tikikun tikikun tikikun left review comments

@hiro-v hiro-v hiro-v approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dotieuthien dotieuthien

Labels

P0: critical Mission critical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build and run Nitro on windows (with or without NVIDIA GPU support)

4 participants

@dotieuthien @tikikun @hiro-v