Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: model id parsing breaks model pull #816

Merged
louis-jan merged 1 commit into from
Jul 3, 2024
Merged

fix: model id parsing breaks model pull #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cortex-js/src/usecases/models/models.usecases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@ export class ModelsUsecases {
throw new BadRequestException('Model already exists');
}

// ONNX only supported on Windows
const modelsContainerDir = await this.fileManagerService.getModelsPath();

if (!existsSync(modelsContainerDir)) {
Expand Down
2 changes: 1 addition & 1 deletion cortex-js/src/utils/huggingface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export async function fetchJanRepoData(
): Promise<HuggingFaceRepoData> {
const repo = modelId.split(':')[0];
const tree = await parseModelHubEngineBranch(
modelId.split(':')[1] ?? !modelId.includes('/') ? 'default' : '',
modelId.split(':')[1] ?? (!modelId.includes('/') ? 'default' : ''),
);
const url = getRepoModelsUrl(
`${!modelId.includes('/') ? 'cortexso/' : ''}${repo}`,
Expand Down