Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: #644 - model start attach mode can just work once #851

Merged
louis-jan merged 1 commit into from
Jul 8, 2024
Merged

fix: #644 - model start attach mode can just work once #851

louis-jan merged 1 commit into from
Jul 8, 2024

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 7, 2024 •
edited
Loading

Describe Your Changes

  • Fixed an issue where cortex models start can just attach once. Where cortex-cpp server shell injection can just done once. Now it observes log file instead. So can attach from any processes.
  • Fixed an issue where the model loading indicator keeps showing when the model is already loaded before.
  • Added Model is running indicator in attached mode

Screenshot 2024-07-07 at 13 33 27

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the fix/644-cortex-start-attach-does-not-work branch from abaf5b6 to f58f139 Compare July 7, 2024 06:51
@louis-jan louis-jan merged commit 828b679 into dev Jul 8, 2024
@louis-jan louis-jan deleted the fix/644-cortex-start-attach-does-not-work branch July 8, 2024 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@namchuai namchuai Awaiting requested review from namchuai

1 more reviewer

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: cortex start -a doesn't attach interactive shell

3 participants

@louis-jan @marknguyen1302