Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@marknguyen1302
Copy link
Contributor

Describe Your Changes

  • add custom model id in download model api
  • fix wrong format in messages,threads,assistants api

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@marknguyen1302 marknguyen1302 requested a review from louis-jan July 15, 2024 05:01
*/
async pullModel(
modelId: string,
hfModelId: string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not always hfModelId format

@louis-jan louis-jan changed the title fix: add custom model id, fix wrong format in messages,threads,assistants api fix: add custom model id Jul 15, 2024
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marknguyen1302 marknguyen1302 merged commit 4a09e8c into dev Jul 15, 2024
@marknguyen1302 marknguyen1302 deleted the fix/add-custom-model-id branch July 15, 2024 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants